Commits

md_5 authored 828f059332b
SPIGOT-7558: Deprecate silenceable lightning API as sound is now client-side and cannot be removed
No tags

Bukkit-Patches/0008-Silenceable-Lightning-API.patch

Modified
1 -From 8389af999d5f43493532693664085577a2fe3b6e Mon Sep 17 00:00:00 2001
1 +From bb1fe92288f21eccdd042e9a1c9f3e59d2ef5842 Mon Sep 17 00:00:00 2001
2 2 From: drXor <mcyoungsota@gmail.com>
3 3 Date: Sun, 23 Feb 2014 16:16:29 -0400
4 4 Subject: [PATCH] Silenceable Lightning API
5 5
6 6
7 7 diff --git a/src/main/java/org/bukkit/World.java b/src/main/java/org/bukkit/World.java
8 -index e3897aab..6e7d5545 100644
8 +index e3897aab..d453a975 100644
9 9 --- a/src/main/java/org/bukkit/World.java
10 10 +++ b/src/main/java/org/bukkit/World.java
11 -@@ -2738,6 +2738,29 @@ public interface World extends RegionAccessor, WorldInfo, PluginMessageRecipient
11 +@@ -2738,6 +2738,35 @@ public interface World extends RegionAccessor, WorldInfo, PluginMessageRecipient
12 12 // Spigot start
13 13 public class Spigot {
14 14
15 15 + /**
16 16 + * Strikes lightning at the given {@link Location} and possibly without sound
17 17 + *
18 18 + * @param loc The location to strike lightning
19 19 + * @param isSilent Whether this strike makes no sound
20 20 + * @return The lightning entity.
21 ++ * @deprecated sound is now client side and cannot be removed
22 ++ * @see World#strikeLightning(org.bukkit.Location)
21 23 + */
22 24 + @NotNull
25 ++ @Deprecated
23 26 + public LightningStrike strikeLightning(@NotNull Location loc, boolean isSilent) {
24 27 + throw new UnsupportedOperationException("Not supported yet.");
25 28 + }
26 29 +
27 30 + /**
28 31 + * Strikes lightning at the given {@link Location} without doing damage and possibly without sound
29 32 + *
30 33 + * @param loc The location to strike lightning
31 34 + * @param isSilent Whether this strike makes no sound
32 35 + * @return The lightning entity.
36 ++ * @deprecated sound is now client side and cannot be removed
37 ++ * @see World#strikeLightningEffect(org.bukkit.Location)
33 38 + */
34 39 + @NotNull
40 ++ @Deprecated
35 41 + public LightningStrike strikeLightningEffect(@NotNull Location loc, boolean isSilent) {
36 42 + throw new UnsupportedOperationException("Not supported yet.");
37 43 + }
38 44 }
39 45
40 46 @NotNull
41 47 diff --git a/src/main/java/org/bukkit/entity/LightningStrike.java b/src/main/java/org/bukkit/entity/LightningStrike.java
42 -index d913298e..c49628f2 100644
48 +index d913298e..b27447d7 100644
43 49 --- a/src/main/java/org/bukkit/entity/LightningStrike.java
44 50 +++ b/src/main/java/org/bukkit/entity/LightningStrike.java
45 -@@ -86,6 +86,14 @@ public interface LightningStrike extends Entity {
51 +@@ -86,6 +86,16 @@ public interface LightningStrike extends Entity {
46 52 // Spigot start
47 53 public class Spigot extends Entity.Spigot {
48 54
49 -+ /*
55 ++ /**
50 56 + * Returns whether the strike is silent.
51 57 + *
52 58 + * @return whether the strike is silent.
59 ++ * @deprecated sound is now client side and cannot be removed
53 60 + */
61 ++ @Deprecated
54 62 + public boolean isSilent() {
55 63 + throw new UnsupportedOperationException("Not supported yet.");
56 64 + }
57 65 }
58 66
59 67 @NotNull
60 68 --
61 69 2.43.0
62 70

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut