Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-2858

StackOverflow upon shift clicking an item into a custom inventory

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Duplicate
    • None
    • None
    • Java 8, Arch Linux

    • N/A

    Description

      This has been reported in the past, but I couldn't find a way to move it back to the top, and it was never assigned to anyone. When you create a custom inventory (of I assume to be just about any type, although I've only tested workbench, dropper, and dispenser) and a player shift clicks an item into it, a StackOverflowError is thrown.

       

      Caused by: java.lang.StackOverflowError
       at java.util.HashMap.putVal(HashMap.java:628) ~[?:1.8.0_112]
       at java.util.HashMap.put(HashMap.java:611) ~[?:1.8.0_112]
       at net.minecraft.server.v1_11_R1.NBTTagCompound.setString(SourceFile:134) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.ItemStack.save(ItemStack.java:282) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.ItemStack.<init>(ItemStack.java:66) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.ItemStack.cloneItemStack(ItemStack.java:444) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:252) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:254) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
       at net.minecraft.server.v1_11_R1.Container.a(Container.java:430) ~[spigot-1.11.jar:git-Spigot-f950f8e-c91ca4a]
      
      

      The last 2 lines seem to recursively call each other, causing the error. The server doesn't crash, but any plugins handling the custom inventory seem to stop being able to do anything do it.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Redempt Anonymous Chicken
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: