• Type: Bug
    • Resolution: Fixed
    • Priority: Minor
    • None
    • Affects Version/s: None
    • Environment:

      java version "1.8.0_60"
      Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
      Java HotSpot(TM) Client VM (build 25.60-b23, mixed mode, sharing)

    • PlotSquared

      Using a created ChunkData object for chunk generation results in lighting issues. `random-light-updates` is enabled.

          [SPIGOT-1753] ChunkGenerator lighting updates

          Made a PR for this: craftbukkit#897

          Marvin Rieple added a comment - Made a PR for this: craftbukkit#897

          Empire92 added a comment - - edited

          @md_5
          Sorry for the poor explanation. So with an example generator:
          https://www.dropbox.com/s/zbu944vlpzmtw8o/TestGen.jar?dl=1
          http://hastebin.com/eriliqamap.java
          http://i.imgur.com/ZGuRNc4.png
          Which creates a floor of stone with a small blob above it and one glowstone block the lighting for chunk isn't initialized properly. There'll be a dark shadow beneath the blob (turn off smooth lighting in the client and it's more evident). The glowstone also doesn't create any light.

          The exception to this; chunks generated when the world is created don't have lighting issues, and using a populator instead of the ChunkData object do not result in the bad lighting. This is also not really a client side issue since lighting is done server side and sent to the client.

          Empire92 added a comment - - edited @md_5 Sorry for the poor explanation. So with an example generator: https://www.dropbox.com/s/zbu944vlpzmtw8o/TestGen.jar?dl=1 http://hastebin.com/eriliqamap.java http://i.imgur.com/ZGuRNc4.png Which creates a floor of stone with a small blob above it and one glowstone block the lighting for chunk isn't initialized properly. There'll be a dark shadow beneath the blob (turn off smooth lighting in the client and it's more evident). The glowstone also doesn't create any light. The exception to this; chunks generated when the world is created don't have lighting issues, and using a populator instead of the ChunkData object do not result in the bad lighting. This is also not really a client side issue since lighting is done server side and sent to the client.

          Zrips added a comment -

          Light updates are not performed when getting close to bugged dark areas. If there is light bug with black spots, in version 1.8 you just need to get close enough for that spot to fix itself. Now its stays black unless you will brake some blocks in that spot, then light update kicks in. Its seams to be client side issue as same thing persists in single player.

          Zrips added a comment - Light updates are not performed when getting close to bugged dark areas. If there is light bug with black spots, in version 1.8 you just need to get close enough for that spot to fix itself. Now its stays black unless you will brake some blocks in that spot, then light update kicks in. Its seams to be client side issue as same thing persists in single player.

          md_5 added a comment -

          Uh what is the issue in this picture?
          Please provide a test case.

          md_5 added a comment - Uh what is the issue in this picture? Please provide a test case.

            Assignee:
            Unassigned
            Reporter:
            Empire92
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: