[SPIGOT-1753] ChunkGenerator lighting updates Created: 05/Mar/16  Updated: 23/Jul/21  Resolved: 23/Jul/21

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Empire92 Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: 1.9
Environment:

java version "1.8.0_60"
Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
Java HotSpot(TM) Client VM (build 25.60-b23, mixed mode, sharing)


Attachments: PNG File 2016-03-05_10.43.52.png    
Plugin: PlotSquared

 Description   

Using a created ChunkData object for chunk generation results in lighting issues. `random-light-updates` is enabled.



 Comments   
Comment by Marvin Rieple [ 22/Jul/21 ]

Made a PR for this: craftbukkit#897

Comment by Empire92 [ 19/Mar/16 ]

@md_5
Sorry for the poor explanation. So with an example generator:
https://www.dropbox.com/s/zbu944vlpzmtw8o/TestGen.jar?dl=1
http://hastebin.com/eriliqamap.java
http://i.imgur.com/ZGuRNc4.png
Which creates a floor of stone with a small blob above it and one glowstone block the lighting for chunk isn't initialized properly. There'll be a dark shadow beneath the blob (turn off smooth lighting in the client and it's more evident). The glowstone also doesn't create any light.

The exception to this; chunks generated when the world is created don't have lighting issues, and using a populator instead of the ChunkData object do not result in the bad lighting. This is also not really a client side issue since lighting is done server side and sent to the client.

Comment by Zrips [ 10/Mar/16 ]

Light updates are not performed when getting close to bugged dark areas. If there is light bug with black spots, in version 1.8 you just need to get close enough for that spot to fix itself. Now its stays black unless you will brake some blocks in that spot, then light update kicks in. Its seams to be client side issue as same thing persists in single player.

Comment by md_5 [ 05/Mar/16 ]

Uh what is the issue in this picture?
Please provide a test case.

Generated at Tue Apr 22 03:00:31 UTC 2025 using Jira 10.3.5#10030005-sha1:190c783f2bd6c69cd5accdb70f97e48812a78d14.