Commits
md_5 authored 494eef45d29
| 14 14 | |
| 15 15 | ##### Pull Request Message Expectations |
| 16 16 | The body of a PR needs to describe how the ticket was resolved, or if there was no ticket, describe the problem itself. |
| 17 17 | If a PR is for both Bukkit and CraftBukkit it should include a link to the appropriate PR. [Read this to learn how to link to a PR.](https://confluence.atlassian.com/bitbucketserver053/markdown-syntax-guide-938022413.html?utm_campaign=in-app-help&utm_medium=in-app-help&utm_source=stash#Markdownsyntaxguide-Linkingtopullrequests) |
| 18 18 | |
| 19 19 | ##### Submitting the Changes |
| 20 20 | * Push your changes to a topic branch in your fork of the repository. |
| 21 21 | * Submit a pull request to the relevant repository in the Spigot organization. |
| 22 22 | * Make sure your pull request meets our [code requirements.](README.md) |
| 23 23 | * If you are fixing a JIRA ticket, be sure to update the ticket with a link to the pull request. |
| 24 + | * All bug fixes must be accompanied by a JIRA ticket. |
| 24 25 | * Ensure all changes (including in patches) have our Minimal Diff Policy in mind. |
| 25 26 | |
| 26 27 | ##### Pull Request Feedback |
| 27 28 | Spigot has a lot of Pull Requests open. Some of these are old and no longer maintained. As a general rule, we do not delete PRs because they are old or abandoned. |
| 28 29 | |
| 29 30 | You will eventually receive feedback on your Pull Requests. If the criticism is rough, do not take it personally. We have all started out, or just made bad PRs. |
| 30 31 | Take the advice and use it to make yourself better. If you think someone is being malicious contact an [admin](https://www.spigotmc.org/XenStaff/#Administrator). |
| 31 32 | |
| 32 33 | Feedback goes both ways. If you believe a feature should be present then be prepared to argue your case. |
| 33 34 | Per our Code Requirements, formatting issues are almost always required to be fixed before a PR is accepted. |