Commits

md_5 authored 11b675fca43
Remove ability to load plugins with spaces in their name.
No tags

src/main/java/org/bukkit/plugin/SimplePluginManager.java

Modified
129 129 if (loader == null) continue;
130 130
131 131 PluginDescriptionFile description = null;
132 132 try {
133 133 description = loader.getPluginDescription(file);
134 134 String name = description.getName();
135 135 if (name.equalsIgnoreCase("bukkit") || name.equalsIgnoreCase("minecraft") || name.equalsIgnoreCase("mojang")) {
136 136 server.getLogger().log(Level.SEVERE, "Could not load '" + file.getPath() + "' in folder '" + directory.getPath() + "': Restricted Name");
137 137 continue;
138 138 } else if (description.rawName.indexOf(' ') != -1) {
139 - server.getLogger().warning(String.format(
140 - "Plugin `%s' uses the space-character (0x20) in its name `%s' - this will not work in Minecraft 1.12",
141 - description.getFullName(),
142 - description.rawName
143 - ));
139 + server.getLogger().log(Level.SEVERE, "Could not load '" + file.getPath() + "' in folder '" + directory.getPath() + "': uses the space-character (0x20) in its name");
140 + continue;
144 141 }
145 142 } catch (InvalidDescriptionException ex) {
146 143 server.getLogger().log(Level.SEVERE, "Could not load '" + file.getPath() + "' in folder '" + directory.getPath() + "'", ex);
147 144 continue;
148 145 }
149 146
150 147 File replacedFile = plugins.put(description.getName(), file);
151 148 if (replacedFile != null) {
152 149 server.getLogger().severe(String.format(
153 150 "Ambiguous plugin name `%s' for files `%s' and `%s' in `%s'",

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut