LivingEntity.setNoDamageTicks​() serves no purpose

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor
    • None
    • Affects Version/s: None
    • None
    • Environment:

      N/A

    • git-Spigot-37d799b-3eb7236 (MC: 1.16.4) (Implementing API version 1.16.4-R0.1-SNAPSHOT)
    • Yes

      Due to a programming oversight, the maxNoDamageTicks field in EntityLiving.java is no longer used.

      This means LivingEntity.setNoDamageTicks​() now does nothing. It sets the value of maxNoDamageTicks, but that field is never used.

      In the past, damageEntity() function in EntityLiving.java used maxNoDamageTicks:

      Now, maxNoDamageTicks is set but never used.

      Recommendation: Consider updating the damageEntity() function in LivingEntity.java so that it makes use of the maxNoDamageTicks field again.

        1. image-2020-12-25-16-33-50-730.png
          image-2020-12-25-16-33-50-730.png
          17 kB
        2. image-2020-12-25-16-35-30-960.png
          image-2020-12-25-16-35-30-960.png
          20 kB

            Assignee:
            Unassigned
            Reporter:
            acbat
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: