Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-6292

LivingEntity.setNoDamageTicks​() serves no purpose

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • None
    • None
    • N/A

    • git-Spigot-37d799b-3eb7236 (MC: 1.16.4) (Implementing API version 1.16.4-R0.1-SNAPSHOT)
    • Yes

    Description

      Due to a programming oversight, the maxNoDamageTicks field in EntityLiving.java is no longer used.

      This means LivingEntity.setNoDamageTicks​() now does nothing. It sets the value of maxNoDamageTicks, but that field is never used.

      In the past, damageEntity() function in EntityLiving.java used maxNoDamageTicks:

      Now, maxNoDamageTicks is set but never used.

      Recommendation: Consider updating the damageEntity() function in LivingEntity.java so that it makes use of the maxNoDamageTicks field again.

      Attachments

        Activity

          People

            Unassigned Unassigned
            acasher acbat
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: