[SPIGOT-6780] Docs for World#spawnFallingBlock not really correct Created: 02/Nov/21 Updated: 16/Apr/23 Resolved: 16/Apr/23 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | Bug | Priority: | Minor |
Reporter: | Shane Bee | Assignee: | Doc |
Resolution: | Fixed | Votes: | 0 |
Labels: | None |
Version: | n/a |
Guidelines Read: | Yes |
Description |
I just noticed the docs for World#spawnFallingBlock, the method using BlockData, does not mention block data, but rather seems copy/pasted from the method that uses material
/** * Spawn a {@link FallingBlock} entity at the given {@link Location} of * the specified {@link Material}. The material dictates what is falling. * When the FallingBlock hits the ground, it will place that block. * <p> * The Material must be a block type, check with {@link Material#isBlock() * material.isBlock()}. The Material may not be air. * * @param location The {@link Location} to spawn the FallingBlock * @param data The block data * @return The spawned {@link FallingBlock} instance * @throws IllegalArgumentException if {@link Location} or {@link * BlockData} are null */ @NotNull public FallingBlock spawnFallingBlock(@NotNull Location location, @NotNull BlockData data) throws IllegalArgumentException; |
Comments |
Comment by Doc [ 02/Nov/21 ] |
Well all the methods use Material (from BlockData) but can be useful indicate this... i made a PR with this changes. https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/670/overview |