[SPIGOT-6373] Shulker API additions Created: 20/Feb/21 Updated: 28/Apr/21 Resolved: 28/Apr/21 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | New Feature | Priority: | Minor |
Reporter: | blablubbabc | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 2 |
Labels: | None |
Attachments: |
![]() ![]() ![]() |
Version: | This server is running CraftBukkit version dev-Spigot-89d6047-c3e684e (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT) |
Guidelines Read: | Yes |
Description |
It's not yet possible to change:
|
Comments |
Comment by Evil Witchdoctor [ 28/Apr/21 ] |
Thank you for adding getAttachedFace()! |
Comment by Julian v.d Berkmortel [ 20/Apr/21 ] |
`isOpen()`, `isClosed()` and `isPeeking()` are redundant, `getPeek()` is enough. Checking if it is either open, closed or peeking can be achieved using `getPeek()`. In regards to why it is implemented as a float rather than a byte, a link to the pull request below in which this was discussed.
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/821/overview |
Comment by FreeSoccerHDX [ 20/Apr/21 ] |
You should provide Methods like isOpen() or isClosed() and also isPeeking() for Users that don't want to find out if Peeking is 50.0 or 100,0 with your Methods. (Also why do you implemented the 'peeking' as Percentage and not with the bytes it rly uses^^) |
Comment by Julian v.d Berkmortel [ 20/Apr/21 ] |
I will look into adding the attached face to the API as well. |
Comment by FreeSoccerHDX [ 04/Apr/21 ] |
Implemented in Shulker: public boolean isPeeking();
(SpigotMC Contributor Licensing is done too) 0102 is from Spigot\CraftBukkit-Patches |