[SPIGOT-6073] Implement custom worlds / biomes from datapacks Created: 13/Aug/20 Updated: 10/Aug/21 Resolved: 10/Aug/21 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | New Feature | Priority: | Minor |
Reporter: | Foxxite | Assignee: | Unassigned |
Resolution: | Done | Votes: | 17 |
Labels: | DataPacks, Dimensions, biomes |
Attachments: |
![]() |
||||||||||||||||
Issue Links: |
|
||||||||||||||||
Version: | CraftBukkit version git-Spigot-379750e-f26d8e8 (MC: 1.16.2) | ||||||||||||||||
Guidelines Read: | Yes |
Description |
Minecraft 1.16.1 has introduced the ability for datapack creators to create custom dimensions and biomes. Minecraft 1.16.2 has majorly expanded on those capabilities. As of now, Spigot doesn't use the dimensions and biomes from datapacks. However it does load custom biomes into memory. Suggestions being self explanatory;
See the attached zip file for a datapack containing custom biomes. The way minecraft handles the custom biomes can be found in net.minecraft.world.level.biome.Biome and net.minecraft.world.level.biome.BiomeManager (this is the same for the server as for the client) |
Comments |
Comment by md_5 [ 10/Aug/21 ] |
Yes |
Comment by Gregory L [ 10/Aug/21 ] |
Are you sure about this? I made a PR for this nearly a year ago and I can't see anything remotely similar in upstream. Unless it's handled somewhere outside of CraftServer and/or WorldCreator? |
Comment by md_5 [ 10/Aug/21 ] |
Support for this was added months ago |
Comment by Gregory L [ 10/Aug/21 ] |
Any updates on this? |
Comment by TheCreeperCow [ 21/Apr/21 ] |
Ah ok in the future make sure you mention that on the ticket so we dont have developer overlapping PR's |
Comment by Gregory L [ 21/Apr/21 ] |
@TheCreeperCow I have already made a PR, it just hasn't been merged yet. 736 |
Comment by TheCreeperCow [ 21/Apr/21 ] |
Ill investigate this feature request as it seems there is a lot of interest in it however i cannot make any promises |
Comment by Matthew Hildebrand [ 26/Sep/20 ] |
I don't expect this to be implemented right away. Does anyone know if there are tools to modify an existing world's biomes with datapack ones in the meantime? |
Comment by Norbert [ 11/Sep/20 ] |
I've made a plugin that can load custom dimensions as worlds, it seems to work so far, of course, if another plugin checks the biome type or something like that might break but I haven't run into issues yet (so use at your own risk): https://www.spigotmc.org/resources/1-16-custom-dimensions.83731/ |
Comment by YourCoal [ 26/Aug/20 ] |
This would be amazing to add support, especially for custom biomes. I hope it's something we can see in the near future! |
Comment by Tucker Andrews [ 25/Aug/20 ] |
How does this WorldCreator thing work? Is it a plugin? I was looking into it and I am very confused. How can I use this? |
Comment by Gregory L [ 25/Aug/20 ] |
I have implemented the ability to load generator settings via WorldCreator: 736. I have also outlined why the Biome class should be updated regardless if the class is implemented. tl;dr you can already import worlds that use the new datapack configuration system, without the need fot this. |
Comment by Yannick Lamprecht [ 16/Aug/20 ] |
@Tucker that's not harsh it is realistic. It would be a cool addition no doubt but as long as no one coming up with an API design for that, that will be stable enough for future, nothing will be implemented. The big thing here is that Mojang developers themselves declaring this feature as likely to change drastically. So supporting a feature, that is likely to change drastically, in an API needs more than just copying stuff present. First step could be that the Biome enum is migrated to a class, keeping binary compatibility like the Bungee ChatColor, so that it could handle dynamic biomes with namespaced keys. Designing the Builder or especially the class that represents the Biome config is a whole other thing. |
Comment by Josiah Bridegroom [ 16/Aug/20 ] |
Sorry if I was complaining. Asking around, everyone I have asked is making it out to be like this feature will never be supported, so I've been getting progressively more and more worried with each response. |
Comment by Tucker Andrews [ 15/Aug/20 ] |
That's a pretty harsh response considering we've been nothing but polite about it. We don't know to implement this stuff, that's why we come to you. That's why we use Spigot. We can't do things like this. We rely on Spigot and it's features.. Telling us to do it ourselves just kinda feels like you're spitting in our face about it. The guy who first started this ticket presented ways to do it - granted, I don't know if it's correct or not, but it looks pretty legit to me.
I read the 1.16 expectations and well.. I don't feel like that applies to us. I don't expect anything, hell, Spigot could shut down at any moment, but requesting an important feature to be added is different. That's not expectations. |
Comment by md_5 [ 15/Aug/20 ] |
No one has straight up said it's not going to be implemented. If it's so easy or important to you why don't you implement it yourself and PR it so everyone can benefit? Hint: because it's hard to do properly. We get the point, you want the feature, but moaning and complaining isn't going to get it implemented. I suggest you refer to the 1.16 announcement regarding expections. |
Comment by Josiah Bridegroom [ 15/Aug/20 ] |
Yes, please add support for this. I delayed updating my server to 1.16 because I had many plans for this feature. Now everything that's been teased to the community can't be implemented and I've done a bunch of work for nothing. |
Comment by Tucker Andrews [ 15/Aug/20 ] |
Exactly, this hurts no one by adding support for it, if it breaks that's on us, we're the ones relying on it. A lot of people were banking on these features and for Spigot to come out and say they straight up aren't going to support it is really disappointing, considering there really are no other options out there. |
Comment by Geradeso Lukas [ 15/Aug/20 ] |
It will be really important for every server especially because the new Custom Biomes support custom Foliage/Sky/Water Tints. And only because it is experimental it doesn't mean people don't want to use it. I mean it doesn't hurt anyone, right? |
Comment by Tucker Andrews [ 15/Aug/20 ] |
This needs to be added, needs. Even if it's experimental, just add the support for them! If it's removed later or broken later, we'll just have to deal with it. |
Comment by Sephiths [ 14/Aug/20 ] |
I was actually really excited to use the custom dimensions for my server. I want to continue to provide a unique, fun game-play experiences whenever possible. I saw this as a great way to do that and promised my server custom dimensions. I hope it's still planned to be implemented soon. Was the main feature in the 1.16.2 update. |
Comment by Foxxite [ 14/Aug/20 ] |
Plus the other updated modded server platforms have them implemented. (But those require client side mods so almost no one uses those) |
Comment by Brokkonaut [ 14/Aug/20 ] |
The details may change but custom biomes will stay. So it would be great if they were supported by spigot. |
Comment by md_5 [ 13/Aug/20 ] |
Among other issues these features are labelled experimental by Mojang |