[SPIGOT-3641] EntityEffect applicable incomlete Created: 07/Nov/17  Updated: 09/Nov/23  Resolved: 07/Nov/17

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Selebrator Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: API, Bukkit

Issue Links:
Relates
relates to SPIGOT-7479 EntityEffect missing some effects Resolved

 Description   

Since the fix for -SPIGOT-3629- each EntityEffect comes with data about what entities are affected by that effect. In Some cases this is incomplete.

  1. DEATH(3, LivingEntity.class) is also used to make Snowballs and Eggs crack
  2. SHEEP_EAT(10, LivingEntity.class) is also used on ExplosiveMinecart to trigger its prime animation
  3. GOLEM_ATTACK(4, IronGolem.class) is also used on EvokerFangs to trigger their biting animation and play the ENTITY_EVOCATION_FANGS_ATTACK sound.

In these cases the missing Entity types are not sub classes of the already given applicable class.

 Comments   
Comment by md_5 [ 09/Nov/23 ]

Resolved - see SPIGOT-7479

Comment by Selebrator [ 28/Aug/18 ]

Would now be a good time to implement the planned changes?

Comment by md_5 [ 07/Nov/17 ]

I have removed SHEEP_EAT and GOLEM_ATTACK since we cannot do duplicate mappings till a deprecated method is removed which must happen in 1.13.
I have removed the LivingEntity constaint on DEATH to restore backwards compatability.

Generated at Sun Mar 30 17:54:37 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.