[#SPIGOT-173] Wrong Scoreboard criteria used

[SPIGOT-173] Wrong Scoreboard criteria used Created: 10/Dec/14 Updated: 10/Dec/14 Resolved: 10/Dec/14
Status:	Closed
Project:	Spigot
Component/s:	None
Affects Version/s:	None
Fix Version/s:	None

Type:

Bug

Priority:

Minor

Reporter:

Black Hole

Assignee:

Thinkofname

Resolution:

Fixed

Votes:

Labels:

1.8, Craftbukkit, Scoreboard

Description

When using the criteria "playerKillCount" it counts for "totalKillCount" instead.
The criteria "deathCount" really counts "playerKillCount". And player deaths are counted as "trigger".

This is because of missed renames in IScoreboardCriteria. They are used in EntityHuman.b(Entity entity, int i) and EntityPlayer.die(DamageSource damagesource)

Comments

Comment by Thinkofname [ 10/Dec/14 ]

Fixed

Comment by Black Hole [ 10/Dec/14 ]

EntityPlayer.die() ist still referencing IScoreboardCriteria.c instead of IScoreboardCriteria.d

Comment by Black Hole [ 10/Dec/14 ]

I'm running a custom spigot version, so the output of "/version" is not meaningful. Before I create an issue I'll always update with the spigot repositories and review the code changes.

Comment by GunfighterJ [ 10/Dec/14 ]

"Latest" is not a version.

Generated at Mon Apr 07 22:29:20 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.

[SPIGOT-173] Wrong Scoreboard criteria used Created: 10/Dec/14 Updated: 10/Dec/14 Resolved: 10/Dec/14