Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-957

Lightcalculation of ChunkSelection faulty implemented resulting in clientbugs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • None
    • [11:52:53 INFO]: [Chunkli] running on Java 1.7.0_80 amd64

      The Code in ChunkSelection.java that reports if a specific part of a chunk needs to be delivered to a client or not is faulty:

      public boolean a() {
      return this.nonEmptyBlockCount == 0;
      }

      The code does not consider the fact that - even if there is no block in a chunkselection - there may still be light-information for that selection.

      This results in light-Bugs on the client side if a Chunk hast light-information in a chunkselection that does not contain any blocks.

      The screenshots show the issue very well. The missing light-information is clearly visible. The faulty chunk has blocks exactly up to 63. At 64 a new Chunkselection starts and the light-Information stored in that selection are not delivered to the client

      This can be fixed by changing the code:
      public boolean a()

      { // return this.nonEmptyBlockCount == 0; return false; //kade fix, bukkit reports wrongly if a part of a chunk is empty or not. }

        1. 2015-06-02_11.59.07.png
          2015-06-02_11.59.07.png
          781 kB
        2. 2015-06-02_11.59.20.png
          2015-06-02_11.59.20.png
          386 kB
        3. 2015-06-02_11.59.32.png
          2015-06-02_11.59.32.png
          576 kB
        4. 2015-06-02_11.59.57.png
          2015-06-02_11.59.57.png
          615 kB

            Unassigned Unassigned
            Kademlia Kademlia
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: