Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-7806

Drops in PlayerDeathEvent and EntityDeathEvent ignore the origin of the drop for Location

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • None
    • None
    • 1.21
    • Yes

      Based in

      https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/aac911d2634a2e51023fa39c3b015b590b46914c#nms-patches%2Fnet%2Fminecraft%2Fserver%2Flevel%2FEntityPlayer.patch

      https://hub.spigotmc.org/jira/browse/SPIGOT-7800

      https://hub.spigotmc.org/jira/browse/SPIGOT-7801

      Currently all the drops are managed in the same list passed to events, this ignore the "origin" and can cause a diff behaviour from vanilla where:

      • LootTable
        • This spawn in the feet of players with not alterations in location
      • Inventory
        • This spawn -0.3 from eyes

      For handle this the options can be:

      • In the events move the drops from loottable to another method like getLootTableDrops() and remove from getDrops(), currently a breaking thing
      • Internally track what items are from what origin and track changes in that item but this is just an horror in maintenance...

            Doc Doc
            Doc Doc
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: