Change the name of enum ItemFlag#HIDE_POTION_EFFECTS

XMLWordPrintable

    • Type: New Feature
    • Resolution: Fixed
    • Priority: Minor
    • None
    • Affects Version/s: None
    • git-Paper-522 (MC: 1.19.4)
    • Yes

      ItemFlag#HIDE_POTION_EFFECTS is an unnecessarily confusing name for an enum that also hides other things like the artist and name of a music disc and perhaps more.

      On Paper, this enum is renamed to ItemFlag#HIDE_ITEM_SPECIFICS, which makes a lot more sense in my opinion.

          [SPIGOT-7355] Change the name of enum ItemFlag#HIDE_POTION_EFFECTS

          Black Hole added a comment - - edited

          Renaming an enum member is not that simple. Even the fork you're referring to just added a constant and deprecated the enum member.
          If the enum member would be renamed it would break a lot of plugins. To some extend this could be handled with Commodore, but you can't override valueOf() of an enum.

          The JavaDoc of this member could be improved to reflect current uses.

          Black Hole added a comment - - edited Renaming an enum member is not that simple. Even the fork you're referring to just added a constant and deprecated the enum member. If the enum member would be renamed it would break a lot of plugins. To some extend this could be handled with Commodore, but you can't override valueOf() of an enum. The JavaDoc of this member could be improved to reflect current uses.

            Assignee:
            Unassigned
            Reporter:
            Rowan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: