[SPIGOT-7355] Change the name of enum ItemFlag#HIDE_POTION_EFFECTS Created: 12/May/23  Updated: 25/Dec/24  Resolved: 24/Apr/24

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: New Feature Priority: Minor
Reporter: Rowan Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: API, Spigot, spigot

Version: git-Paper-522 (MC: 1.19.4)
Guidelines Read: Yes

 Description   

ItemFlag#HIDE_POTION_EFFECTS is an unnecessarily confusing name for an enum that also hides other things like the artist and name of a music disc and perhaps more.

On Paper, this enum is renamed to ItemFlag#HIDE_ITEM_SPECIFICS, which makes a lot more sense in my opinion.

 Comments   
Comment by Black Hole [ 13/May/23 ]

Renaming an enum member is not that simple. Even the fork you're referring to just added a constant and deprecated the enum member.
If the enum member would be renamed it would break a lot of plugins. To some extend this could be handled with Commodore, but you can't override valueOf() of an enum.

The JavaDoc of this member could be improved to reflect current uses.

Generated at Tue Apr 08 03:01:16 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.