Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-7187

Support non-ASCII characters in Brigadier commands


    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • None
    • NIL

    • 3608-Spigot-6198b5a-b5aa0be (1.19.2)
    • Yes

      Firstly, I apologize if this isn't the right place for discussing this.

      I figured it will be better if I got a general consensus on whether Spigot is willing to accept a pull request for this.

      In recent versions of Spigot (1.19+), executing/parsing of commands performed by players is routed through Brigadier. However, Brigadier's `StringReader.readUnquoted()` method only understands ASCII characters, https://github.com/Mojang/brigadier/blob/master/src/main/java/com/mojang/brigadier/StringReader.java#L169, what this means for end-users is the inability to use non-ASCII as arguments/command names, https://github.com/Pante/chimera/issues/329#issuecomment-962440145.

      I've tried creating a issue for it in Brigadier, almost a year ago, https://github.com/Mojang/brigadier/issues/103, but like all other issues was ignored.

      I've noticed that Spigot contains its own copy of modified Brigadier classes like `CommandDispatcher` and `CommandNode`. Will Spigot be willing to accept a patch which contains a modified `StringReader.readUnquoted()` that fixes this issue?

            Unassigned Unassigned
            PanteLegacy Matthias Ngeo
            0 Vote for this issue
            3 Start watching this issue