(Chunk) PersistentData is lost after restart

XMLWordPrintable

    • CraftBukkit version 3323-Spigot-7514aa3-c86a3f7 (MC: 1.18 Release Candidate 3) (Implementing API version 1.18-rc3-R0.1-SNAPSHOT)
    • Yes

      Reproduce Steps:
      Start 1.18-rc3 Spigot Server with the Reproduction Plugin. Join the Server and enter `/testpersistent set test` and then to check if the Data is saved `/testpersistent get`. Restart the server and rejoin. `/testpersistent get` should output the same, but it doesn't. When using 1.17.1 it works.

      Reproduction plugin source: https://github.com/byquanton/testpersistentdat

        1. image-2021-11-28-19-51-52-500.png
          image-2021-11-28-19-51-52-500.png
          66 kB
        2. image-2021-11-28-19-53-36-300.png
          image-2021-11-28-19-53-36-300.png
          87 kB
        3. image-2021-11-28-20-07-16-800.png
          image-2021-11-28-20-07-16-800.png
          76 kB
        4. testpersistentdata-1.0-SNAPSHOT.jar
          5 kB

          [SPIGOT-6814] (Chunk) PersistentData is lost after restart

          Marvin Rieple added a comment -

          Made a PR for this: craftbukkit#965

          Marvin Rieple added a comment - Made a PR for this: craftbukkit#965

          md_5 added a comment -

          Please do not link patches outside of the stash, we take the integrity of the CLA extremely seriously.

          md_5 added a comment - Please do not link patches outside of the stash, we take the integrity of the CLA extremely seriously.

          byquanton added a comment -

          TL;RD  Loading the Data will delete it and the data is only saved when there are other changes in the chunk

          I did some testing. It looks like the Server only saves the PersistentDataContainer in a chunk when there is a change (like @MrDoc94 mentioned). But if you start a 1.18 Server, the Data in the Chunks will be deleted (Upgrading the World also Deletes Data).

          byquanton added a comment - TL;RD  Loading the Data will delete it and the data is only saved when there are other changes in the chunk I did some testing. It looks like the Server only saves the PersistentDataContainer in a chunk when there is a change (like @MrDoc94 mentioned). But if you start a 1.18 Server, the Data in the Chunks will be deleted (Upgrading the World also Deletes Data).

          Doc added a comment -

          Confirmed... this issue happen when change PersistentDataContainer in a chunk and this chunk not has another change...

           

          For example if you run the command and put a random block in the chunk then the chunk is saved with the PersistentDataContainer correctly... if not then the chunk keep for not saving.

          Doc added a comment - Confirmed... this issue happen when change PersistentDataContainer in a chunk and this chunk not has another change...   For example if you run the command and put a random block in the chunk then the chunk is saved with the PersistentDataContainer correctly... if not then the chunk keep for not saving.

          mfnalex added a comment -

          Was going to report this too right now. 

          mfnalex added a comment - Was going to report this too right now. 

            Assignee:
            Marvin Rieple
            Reporter:
            byquanton
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: