Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-6492

PortalCreateEvent#getBlocks() returns not all blocks by reason fire

    XMLWordPrintable

Details

    • This server is running CraftBukkit version 3092-Spigot-9fb885e-ebe18b9 (MC: 1.16.5)
    • Yes

    Description

      The PortalCreateEvent does not return the correct amount of blocks. It only returns the portal blocks and a single obsidian left and right (See picture). In version 1.15.2 and 1.14.4 more blocks of the frame are present in the list, but still not all (See second picture). I didn't test it in 1.13.2, since the methode changed from 1.13.2 to 1.14.4.

      Going from the description of the event, the old behavior and the behavior of the reason nether pair. getBlocks should return all obsidian blocks of the frame.

      The cause is in the patch BlockPortalShape where not at all places the blocks are added to the list. A PR to fix this can be found here.

       

      The provided test plugin prints the amount of blocks in the list and the reason to the console. It also places the blocks which are present in the list 10 blocks higher in the air. (orange wool for obsidian and purple for nether portal). The source of the test plugin can be seen here.

      Attachments

        1. 1.14.4-1.15.2.png
          1.14.4-1.15.2.png
          244 kB
        2. 1.16.4.png
          1.16.4.png
          81 kB
        3. test-plugin-1.0-SNAPSHOT.jar
          4 kB

        Activity

          People

            Unassigned Unassigned
            DerFrZocker Marvin Rieple
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: