isSimilar for filled maps fails on inventory click event

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor
    • None
    • Affects Version/s: None
    • None
    • This server is running CraftBukkit version git-Spigot-ff439d1-ff2b944 (MC: 1.16.4) (Implementing API version 1.16.4-R0.1-SNAPSHOT)
    • Yes

      When you click on a filled map, the item in the InventoryClickEvent is not similar to the one you added to the inventory.

      Example Code:

      public class CommandTestItem extends SimplePlayerCommand implements Listener {
      
          private ItemStack itemStack;
      
          public CommandTestItem() {
              super("testitem", Rank.DEVELOPER);
              Bukkit.getPluginManager().registerEvents(this, SkyBlockSpawn.a());
              this.itemStack = createItem();
          }
      
          @Override
          public void onCommand(Player player, String[] strings) {
              Inventory inv = Bukkit.createInventory(player, 9, "Test Inv");
              inv.setItem(0, itemStack);
      
              player.openInventory(inv);
          }
      
          @EventHandler
          public void onInvClick(InventoryClickEvent e){
              if(e.getView().getTitle().equals("Test Inv")){
                  if(e.getCurrentItem() != null){
                      e.getWhoClicked().sendMessage("Similar: " + itemStack.isSimilar(e.getCurrentItem()));
                  }
              }
          }
      
          private ItemStack createItem(){
              ItemStack itemStack = new ItemStack(Material.FILLED_MAP);
              MapMeta mapMeta = (MapMeta) itemStack.getItemMeta();
              mapMeta.setColor(DyeColor.GREEN.getColor());
              mapMeta.setLocationName("");
              mapMeta.addItemFlags(ItemFlag.HIDE_ATTRIBUTES);
              mapMeta.addItemFlags(ItemFlag.HIDE_PLACED_ON);
              mapMeta.addItemFlags(ItemFlag.HIDE_POTION_EFFECTS);
              mapMeta.addItemFlags(ItemFlag.HIDE_DESTROYS);
              mapMeta.addItemFlags(ItemFlag.HIDE_UNBREAKABLE);
      
              itemStack.setItemMeta(mapMeta);
              return itemStack;
          }
      }
      

      Output: Similar: false

            Assignee:
            Unassigned
            Reporter:
            Foorcee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: