Chunk persistent data container reads entire chunk data

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major
    • None
    • Affects Version/s: None
    • Environment:

      Of no importance

    • 1.16.3
    • Yes

      With [this commit](https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/77c894a2aba54cf2a0d9e8503fb97f874af68264) spigot introduces PDCs for Chunks, but the loader code reads the entire chunk nbt compound into the persistent data container instead of just the bukkit values field.

      This causes the chunk to literally double its size every time it is stored, by storing itself including the PDC value in its own PDC over and over each write.

      https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/760

       

      This PR aims to fix that issue as well as improve the check for a BukkitValues key in the first place

            Assignee:
            Unassigned
            Reporter:
            Bjarne Koll
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: