NPE in CraftHumanEntity#openWorkbench & CraftHumanEntity#openEnchanting

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor
    • None
    • Affects Version/s: None
    • Environment:

      N/A

    • N/A
    • Yes

      In the implementation for openWorkbench and openEnchanting in CraftHumanEntity, the location null check is below the first use of the location object. This will create an NPE if the location parameter is null and the force parameter is false.

      Player player = Bukkit.getPlayer("md_5");
player.openWorkbench(null, false); //Throws NPE 

      Can be fixed by moving the location null check above force check like so.

       

      if (!force) {
    Block block = location.getBlock();
    if (block.getType() != Material.CRAFTING_TABLE) {
        return null;
    }
}
if (location == null) {
    location = getLocation();
}

// becomes

if (location == null) {
    location = getLocation();
}
if (!force) {
    Block block = location.getBlock();
    if (block.getType() != Material.CRAFTING_TABLE) {
        return null;
    }
}

       

       

            Assignee:
            md_5
            Reporter:
            JRoy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: