Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-4598

Spigot crash with shift+left/right-click on custom Workbench inventory

XMLWordPrintable

    • git-Spigot-518206a-a5b9c7b
    • Yes

      Hello,

       

      I created a plugin which open a workbench inventory to players. This workbench looks like a normal one, but impossible to craft any item in it (I think, because GUI open with a plugin and not by a right-click on workbench). I don't know if it's normal, but that's what I want.

       

      The real problem is this one : when I use the minecraft native keyboard shortcut to swap item slots (with shift+left-click), the server crash. Without any error in a first time, just this crash report after a small waiting time :

      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: The server has stopped responding! This is (probably) not a Spigot bug.
      [00:12:19 ERROR]: If you see a plugin in the Server thread dump below, then please report it to that author
      [00:12:19 ERROR]:        *Especially* if it looks like HTTP or MySQL operations are occurring
      [00:12:19 ERROR]: If you see a world save or edit, then it means you did far more than your server can handle at once
      [00:12:19 ERROR]:        If this is the case, consider increasing timeout-time in spigot.yml but note that this will replace the crash with LARGE lag spikes
      [00:12:19 ERROR]: If you are unsure or still think this is a Spigot bug, please report to https://www.spigotmc.org/
      [00:12:19 ERROR]: Be sure to include ALL relevant console errors and Minecraft crash reports
      [00:12:19 ERROR]: Spigot version: git-Spigot-518206a-a5b9c7b (MC: 1.13.2)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]:               org.bukkit.craftbukkit.v1_13_R2.util.TerminalConsoleWriterThread.run(TerminalConsoleWriterThread.java:35)
      [00:12:19 ERROR]:               java.lang.Thread.run(Unknown Source)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: DestroyJavaVM
      [00:12:19 ERROR]:       PID: 21 | Suspended: false | Native: false | State: RUNNABLE
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Server thread
      [00:12:19 ERROR]:       PID: 19 | Suspended: false | Native: false | State: RUNNABLE
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]:               com.google.common.base.Preconditions.checkPositionIndex(Preconditions.java:1204)
      [00:12:19 ERROR]:               com.google.common.collect.Iterators.forArray(Iterators.java:1001)
      [00:12:19 ERROR]:               com.google.common.collect.RegularImmutableList.listIterator(RegularImmutableList.java:68)
      [00:12:19 ERROR]:               com.google.common.collect.ImmutableList.listIterator(ImmutableList.java:390)
      [00:12:19 ERROR]:               com.google.common.collect.ImmutableList.iterator(ImmutableList.java:385)
      [00:12:19 ERROR]:               com.google.common.collect.ImmutableList.iterator(ImmutableList.java:57)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.PlayerInventory.getItem(PlayerInventory.java:549)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.Slot.getItem(SourceFile:72)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.Container.shiftClick(Container.java:114)
      [00:12:19 ERROR]:               org.bukkit.craftbukkit.v1_13_R2.inventory.CraftContainer.shiftClick(CraftContainer.java:207)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.Container.a(Container.java:249)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:2135)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.PacketPlayInWindowClick.a(SourceFile:33)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.PacketPlayInWindowClick.a(SourceFile:10)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.PlayerConnectionUtils.a(SourceFile:10)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.PlayerConnectionUtils$$Lambda$1936/437286238.run(Unknown Source)
      [00:12:19 ERROR]:               java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
      [00:12:19 ERROR]:               java.util.concurrent.FutureTask.run(Unknown Source)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.SystemUtils.a(SourceFile:199)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:895)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:417)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:830)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:728)
      [00:12:19 ERROR]:               java.lang.Thread.run(Unknown Source)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Server Infinisleeper
      [00:12:19 ERROR]:       PID: 20 | Suspended: false | Native: false | State: TIMED_WAITING
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]:               java.lang.Thread.sleep(Native Method)
      [00:12:19 ERROR]:               net.minecraft.server.v1_13_R2.DedicatedServer$1.run(DedicatedServer.java:66)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: NonBlockingInputStreamThread
      [00:12:19 ERROR]:       PID: 17 | Suspended: false | Native: false | State: WAITING
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]:               java.lang.Object.wait(Native Method)
      [00:12:19 ERROR]:               org.bukkit.craftbukkit.libs.jline.internal.NonBlockingInputStream.run(NonBlockingInputStream.java:278)
      [00:12:19 ERROR]:               java.lang.Thread.run(Unknown Source)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Snooper Timer
      [00:12:19 ERROR]:       PID: 15 | Suspended: false | Native: false | State: WAITING
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]:               java.lang.Object.wait(Native Method)
      [00:12:19 ERROR]:               java.lang.Object.wait(Unknown Source)
      [00:12:19 ERROR]:               java.util.TimerThread.mainLoop(Unknown Source)
      [00:12:19 ERROR]:               java.util.TimerThread.run(Unknown Source)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Attach Listener
      [00:12:19 ERROR]:       PID: 5 | Suspended: false | Native: false | State: RUNNABLE
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Signal Dispatcher
      [00:12:19 ERROR]:       PID: 4 | Suspended: false | Native: false | State: RUNNABLE
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Finalizer
      [00:12:19 ERROR]:       PID: 3 | Suspended: false | Native: false | State: WAITING
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]:               java.lang.Object.wait(Native Method)
      [00:12:19 ERROR]:               java.lang.ref.ReferenceQueue.remove(Unknown Source)
      [00:12:19 ERROR]:               java.lang.ref.ReferenceQueue.remove(Unknown Source)
      [00:12:19 ERROR]:               java.lang.ref.Finalizer$FinalizerThread.run(Unknown Source)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 ERROR]: Current Thread: Reference Handler
      [00:12:19 ERROR]:       PID: 2 | Suspended: false | Native: false | State: WAITING
      [00:12:19 ERROR]:       Stack:
      [00:12:19 ERROR]:               java.lang.Object.wait(Native Method)
      [00:12:19 ERROR]:               java.lang.Object.wait(Unknown Source)
      [00:12:19 ERROR]:               java.lang.ref.Reference.tryHandlePending(Unknown Source)
      [00:12:19 ERROR]:               java.lang.ref.Reference$ReferenceHandler.run(Unknown Source)
      [00:12:19 ERROR]: ------------------------------
      [00:12:19 INFO]: Startup script './start.sh' does not exist! Stopping server.
      [00:12:19 INFO]: Stopping server
      [00:12:19 INFO]: [LeatherTier] Disabling LeatherTier v0.1
      [00:12:19 INFO]: [AttributeEditor] Disabling AttributeEditor v0.2
      [00:12:19 INFO]: [LuckPerms] Disabling LuckPerms v4.3.73
      [00:12:20 INFO]: [LuckPerms] Closing storage...
      [00:12:20 INFO]: [LuckPerms] Shutting down internal scheduler...
      [00:12:20 INFO]: [LuckPerms] Goodbye!
      [00:12:20 INFO]: Saving players
      [00:12:20 INFO]: Bullobily lost connection: Server closed
      [00:12:20 INFO]: Bullobily left the game
      [00:12:20 INFO]: Saving worlds
      [00:12:20 INFO]: Saving chunks for level 'world'/minecraft:overworld
      [00:12:20 INFO]: Saving chunks for level 'world_nether'/minecraft:the_nether
      [00:12:20 INFO]: Saving chunks for level 'world_the_end'/minecraft:the_end
      >Appuyez sur une touche pour continuer...
      

      Even if I test before any instruction that the click type is right-click or left-click (and return the eventhandler otherwise), the plugin crash. I really think it's a spigot bug, not a plugin bug.

       

      Thanks to the Spigot team !

      Bullobily

            md_5 md_5
            Bullobily Bullobily
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: