Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-3977

Horse variants & Llama - getStorageContents contain "non-storage" slot

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • CraftBukkit version git-Spigot-642f6d2-fbe3046 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

    • Spigot-1.12.2

    Description

      Currently (Spigot-1.12.2), calling Inventory.getStorageContents  _ (_instanceof AbstractHorseInventory) on Llama and all horse variant will return exactly the same as Inventory.getContents, including 2 "non-storage" slot.

      In Vannila Minecraft, Horse have 2 "non-storage" slots, one for saddle, one for horse armor, but all other horse variant have only 1 "non-storage" slot for saddle. Llama otherwise have only 1 "non-storage" slot for carpet.

      I think that there is some change should be made:

      • getStorageContents for Llama and all horse variant shouldn't include that 2 "non-storage" slot.
      • Llama Inventory should not be instanceof AbstractHorseInventory, only instanceof LlamaInventory.
      • LlamaInventory should have 1 "non-storage" slot for carpet, have getDecor, setDecor but not getSaddle, setSaddle.

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            mrmathami MrMaThaMi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: