• Type: Bug
    • Resolution: Won't Fix
    • Priority: Minor
    • None
    • Affects Version/s: None

      Commit 4acd0f49e07 has imposed a maximum of 50 pages per book. Even though an in-game player cannot himself create books with more than 50 pages, the client can handle books with many more pages without any issues.

      This limitation has broken books functionality on many servers. For instance, speaking as the author of the Advanced Achievements plugin, players that have received over 50 achievements have been reporting that their books (listing one achievement per page) are now trimmed down to 50 pages, which is a very low limit.

      Similar discussions were done in SPIGOT-3214 (and related commit [
      fecf4b4137c|https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/fecf4b4137c5ce01fb18b697da244a6753b35c2b]).

       

          [SPIGOT-3233] Books: limitation to the number of pages

          Brokkonaut added a comment -

          I would still recommend to limit the book size only for books that are created by the client (book update/signing and creative item creation) Books that are created by the server/plugins should only be limited to the clients limits.

          Brokkonaut added a comment - I would still recommend to limit the book size only for books that are created by the client (book update/signing and creative item creation) Books that are created by the server/plugins should only be limited to the clients limits.

          @md_5 This really screws over some servers such as mine that use these just for a comprehensive reading piece to our server.  I honestly think this should be allowed to be overridden at the plugin developers own risk since it can handle it.  This completely screws with a lot of the textbooks on my HP server bc now we can't even finish 3 chapters of some of them.

          Kimberly Boynton added a comment - @md_5 This really screws over some servers such as mine that use these just for a comprehensive reading piece to our server.  I honestly think this should be allowed to be overridden at the plugin developers own risk since it can handle it.  This completely screws with a lot of the textbooks on my HP server bc now we can't even finish 3 chapters of some of them.

          md_5 added a comment -

          Each page causes lag on the server.
          50 pages is the maximum the client can create, so this is the best number for us to cap it at.
          Capping it at the maximum the client could read (32768) would be the same as just not capping it at all. This isn't acceptable from a security standpoint.

          md_5 added a comment - Each page causes lag on the server. 50 pages is the maximum the client can create, so this is the best number for us to cap it at. Capping it at the maximum the client could read (32768) would be the same as just not capping it at all. This isn't acceptable from a security standpoint.

            Assignee:
            Unassigned
            Reporter:
            Pyves
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: