Uploaded image for project: 'Spigot'
  1. Spigot
  2. SPIGOT-1489

CraftInventoryPlayer#getHolder() throws NPE instead of returning Null.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Minor Minor
    • None
    • None
    • Spigot + MassiveCore

      MassiveCore makes use of reflection to clone player inventories. This is very useful since custom player inventories as provided by the Bukkit API does not provide armor slot support.

      A player brought to my attention that this some times will cause an NPE:
      https://www.spigotmc.org/threads/massivebooks.35756/page-2#post-1283791
      http://puu.sh/mTql9/01346092f4.txt

      It happens at the following line in CraftBukkit
      https://gyazo.com/490118d4bbdaa03a4bc09a7f352437ff

      This is the current section in NMS:
      https://gyazo.com/9a663a255730365838fdf8db33cc4e71

      I kindly ask that you add the following NPE evasion line:
      https://gyazo.com/447dfda9d63d3d2bbb426d1215deacd4

            Unassigned Unassigned
            Cayorion Cayorion
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: