Skip to content
Success

Changes

Summary

  1. Fix issues cleaning up after repeating tasks. (commit: 36c4af3) (details)
  2. Further fix task clean up issues by moving the BungeeScheduler's (commit: 972b4c1) (details)
Commit 36c4af35de3852c6038d3a62856d9b9378fb3939 by md_5
Fix issues cleaning up after repeating tasks.

A mass of NullPointerExceptions would be outputted when tasks were stopped. This is resolved by checking if we are still running (indicating a possible scheduler cancel) before telling the scheduler to pull the plug.

Ideally, the entire BungeeCord scheduler should be rewritten. It has quite a few issues which could be avoided with a new system.
(commit: 36c4af3)
The file was modifiedproxy/src/main/java/net/md_5/bungee/scheduler/BungeeTask.java
Commit 972b4c1fe5f085a39bc5abb12f568a691ffa23fb by md_5
Further fix task clean up issues by moving the BungeeScheduler's cancel(ScheduledTask) method to just call the cancel() method on the task. The cancel call was moved to BungeeTask's cancel method.

This patch makes the patch transparent to existing callers using cancel(ScheduledTask) from the scheduler. It also simplifies some logic in BungeeTask itself.
(commit: 972b4c1)
The file was modifiedproxy/src/main/java/net/md_5/bungee/scheduler/BungeeScheduler.java
The file was modifiedproxy/src/main/java/net/md_5/bungee/scheduler/BungeeTask.java