Skip to content
Success

Changes

Summary

  1. SPIGOT-6194: Read correct nbt compound into chunk pdc (details)
Commit 9e91bcabf29a5ef9bbfef8d0660c46bc243eaf35 by md_5
SPIGOT-6194: Read correct nbt compound into chunk pdc

Previously spigots chunk pdc loading logic would read the entire chunk
nbt compound into the persistent data container of the chunk instead of
just reading the "BukkitValues".

Furthermore this commit also now correctly checks if the nbt compounds
of entities, tile entities and chunks actually have a value for the
"BukkitValues" key, as the previous 'getCompound' call would always
return an instance, the null check was useless. This commit now uses
'get', which returns null if no key exists and then runs an instanceof
check to both validate a non-null instance and an NBTTagCompound
instance.
The file was modifiednms-patches/ChunkRegionLoader.patch
The file was modifiednms-patches/TileEntity.patch
The file was modifiedsrc/main/java/org/bukkit/craftbukkit/entity/CraftEntity.java