Commits
Senmori authored and md_5 committed c1a0994aa66
| 18 18 | |
| 19 19 | Contributing |
| 20 20 | ------------ |
| 21 21 | Contributions of all sorts are welcome. To manage community contributions, we use the pull request functionality of Stash. In to gain access to Stash and create a pull request, you will first need to perform the following steps: |
| 22 22 | |
| 23 23 | * Create an account on [JIRA](http://hub.spigotmc.org/jira/). |
| 24 24 | * Fill in the [SpigotMC CLA](http://www.spigotmc.org/go/cla) and wait up to 24 hours for your Stash account to be activated. Please ensure that your username and email addresses match. |
| 25 25 | * Log into Stash using your JIRA credentials. |
| 26 26 | |
| 27 27 | Once you have performed these steps you can create a fork, push your code changes, and then submit it for review. |
| 28 + | |
| 29 + | Bukkit's Goals |
| 30 + | -------------- |
| 31 + | |
| 32 + | As a rough guideline, ask yourself the following questions to determine if the proposed change fits the Bukkit project's goals. Please remember that this is only a rough guideline |
| 33 + | and it may or may not reflect the definitive answer to this question. |
| 34 + | Discussions about proposed changes are held in the [Spigot IRC](https://www.spigotmc.org/wiki/irc-guide/). |
| 35 + | |
| 36 + | * Does it expose an implementation detail of the server software, or the protocol or file formats? |
| 37 + | |
| 38 + | 1. If your change revolves around an implementation detail then it is not proper API design. Examples of bad API design would be along the lines of |
| 39 + | a packet API or an NBT storage API. |
| 40 + | * Does it result in unexpected behaviour as defined by the Vanilla specification? |
| 41 + | 1. One of the goals of the Bukkit project is to be an extended Minecraft Server. Meaning if you choose to run the Bukkit server without any plugin, it should function |
| 42 + | exactly as the Minecraft Server would with some rare exceptions. If your change alters the behaviour of the server in such a way that you would not have the same experience as you |
| 43 + | would in Vanilla, your change does not fit with the Bukkit project's goals. |
| 44 + | * Does it expose an issue or vulnerability when operating within the Vanilla environment? |
| 45 + | 1. One of the goals of the Bukkit project is to be able to operate within the limitations of the Vanilla environment. If your change results in, or exposes, the ability to, for example, |
| 46 + | crash the client invalid data is set, it does not fit the Bukkit project's needs. |
| 47 + | |
| 48 + | If you answered yes to any of these questions, chances are high your change does not fit within the Bukkit project's goals and will likely not be accepted. |
| 49 + | Regardless, there are a few other important questions that need to be asked before you start working on a change: |
| 50 + | * Is this change reasonably supportable and maintainable? |
| 51 + | 1. *Are there tests for this change? Does this change rely on magic numbers?* |
| 52 + | * Is this change reasonably future proof? |
| 53 + | |
| 54 + | Code Requirements |
| 55 + | ----------------- |
| 56 + | * For the most part, CraftBukkit and Bukkit use the [Sun/Oracle coding standards](http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html). |
| 57 + | * No tabs; use 4 spaces instead. |
| 58 + | * Empty lines should contain no spaces. |
| 59 + | * No trailing whitespaces. |
| 60 + | * No 80 character column limit, or 'weird' mid-statement newlines unless absolutely necessary. |
| 61 + | * No one-line methods. |
| 62 + | * All major additions should have documentation(e.g. javadocs). |
| 63 + | * Try to follow test driven development where available. |
| 64 + | * All code should be free of magic values. If this is not possible, it should be marked with a TODO comment indicating it should be addressed in the future. |
| 65 + | |
| 66 + | Bukkit/CraftBukkit employs [JUnit 4](http://www.vogella.com/articles/JUnit/article.html) for testing. Pull Requests(PR) should attempt to integrate within that framework as appropriate. |
| 67 + | Bukkit is a large project and what seems simple to a PR author at the time of writing may easily be overlooked by other authors and updates. Including unit tests with your PR |
| 68 + | will help to ensure the PR can be easily maintained over time and encourage the Spigot team to pull the PR. |
| 69 + | |
| 70 + | * There needs to be a new line at the end of every file. |
| 71 + | * Absolutely no wildcard imports. |