[SPIGOT-836] Some sticky pistons don't retract blocks Created: 25/Apr/15 Updated: 04/Jun/15 Resolved: 06/May/15 |
|
| Status: | Closed |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | zombachu | Assignee: | Unassigned |
| Resolution: | Invalid | Votes: | 0 |
| Labels: | 1.8.3, Spigot, bug, piston, redstone, retract | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Description |
|
Updating to the latest Spigot build has caused some sticky pistons to no longer retract blocks. This is a new issue caused by one of the latest builds (pistons acted normally in the build I was using that's a couple months old). From initial testing it seems to be locationally based on the z axis (not 100% sure this is always the case though). Here's a very simple setup that shows the problem. No 0 tick pulses, no buds, just a lever next to a piston. (doesn't retract the block) |
| Comments |
| Comment by PseudoKnight [ 06/May/15 ] |
|
I'm not sure why this was invalidated, but it's still an issue. My apologies for not being specific enough, but getRetractLocation() is returning the wrong location (the correct distance but opposite direction from the piston it should return). |
| Comment by MattBDev [ 28/Apr/15 ] |
|
The incorrect data is the reason plotme causes this issue. I had to modify plotme's code to attempt to fix it but it broke even more. I am working on a patch for craftbukkit to modify the event. |
| Comment by zombachu [ 28/Apr/15 ] |
|
After testing Michael's suggestion, the problem does seem to indeed lie with PlotMe. If PlotMe's removed then pistons function normally. However, this issue has only become apparent in the latest builds of Spigot, so perhaps Michael's guess about the incorrect data could be correct... |
| Comment by PseudoKnight [ 27/Apr/15 ] |
|
I'm not talking about a plugin bug. It's a Spigot bug demonstrated in this image when combined with piston protection plugins. You can clearly see that the piston is facing away from the plot border. So based on the data that the plugin receives from Spigot, it thinks it's pulling a block from outside the plot. (the opposite direction) I'd have to look at another example to determine that this isn't the same issue. If zombachu wants to remove all plugins and test again, that would determine whether they're related or not. Either way, there is a bug with the retraction event. |
| Comment by MattBDev [ 27/Apr/15 ] |
|
Michael we are not discussing the plugin bug. we are talking about an issue that possibly affects servers without plugins |
| Comment by PseudoKnight [ 27/Apr/15 ] |
|
The direction and block list are incorrect from the event. If a sticky piston is facing East, it says West. It gives the block facing West even though it tried to pull the block facing East. So pistons facing away from region/plot boundaries are affected, as demonstrated in this image. |
| Comment by zombachu [ 26/Apr/15 ] |
|
Yeah, I took that picture there since it was a location that I saved the coordinates of, but I've seen this happen more than 10 blocks away from the border. |
| Comment by MattBDev [ 26/Apr/15 ] |
|
Have you tried it with a piston that is not next to the plot border? 1.8 messed up pistons and caused odd piston behavior in Plotme. |
| Comment by zombachu [ 25/Apr/15 ] |
|
The only thing that changed was the Spigot build, so plugins shouldn't really matter, but anyways here's the plugins that I'm using: WorldEdit, CoreProtect, Buycraft, PermissionsEx, PlotMe, LoginSecurity, PlotMe-DefaultGenerator, WorldGuard, CleanroomGenerator, Essentials, VanishNoPacket, EssentialsChat, Multiverse-Core, Multiverse-Portals, Multiverse-Inventories, Multiverse-NetherPortals |
| Comment by tkausl [ 25/Apr/15 ] |
|
Plugins? |