[SPIGOT-7773] PlayerInteractEvent raycast does not account for new Minecraft reach attributes Created: 17/Jun/24  Updated: 25/Dec/24  Resolved: 17/Jun/24

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Timo McGrath Assignee: Unassigned
Resolution: Done Votes: 0
Labels: event

Version: This server is running CraftBukkit version 4195-Spigot-fcd94e2-f057cf4 (MC: 1.20.6) (Implementing API version 1.20.6-R0.1-SNAPSHOT)
Guidelines Read: Yes

 Description   

Raycasts for PlayerInteractEvent in PlayerConnection.java should account for new Minecraft reach attributes, both entity and block.
I'm running into the issue that PlayerInteractEvent fires after EntityDamageByEntityEvent whenever I give an item an interact reach modifier. If you attack an entity OUTSIDE of the vanilla reach range, PlayerInteractEvent will still fire.

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches/net/minecraft/server/network/PlayerConnection.patch#722
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches/net/minecraft/server/network/PlayerConnection.patch#1126

I don't think this is as simple as changing the ternary to {{this.player.blockInteractionRange()
}}
For example, a players block interaction range can still be shorter than the players attack interaction range. The raycast needs to account for the longer attribute when checking the logic, but still get the block from the players blockInteractionRange.

 Comments   
Comment by md_5 [ 17/Jun/24 ]

This is fixed in 1.21

Generated at Thu Apr 03 16:57:56 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.