[SPIGOT-7587] Unneeded MC-109346 and MC-142590 bug fix in Craftbukkit Created: 18/Feb/24 Updated: 25/Dec/24 Resolved: 09/Mar/24 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | mrjasonn | Assignee: | Doc |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | redundant-code | ||
| Version: | This server is running CraftBukkit version 4045-Spigot-c198da2-38fd4bd (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) |
| Guidelines Read: | Yes |
| Description |
|
There is an unneeded bug fix of MC-109346 and MC-142590 in Craftbukkit and MC-109346 been fixed in the base game in 1.20.2 Pre-release 2, MC-142590 has been fixed in 22w03a. The fix for MC-109346 is in the EntityTrackerEntry NMS patch class. |
| Comments |
| Comment by mrjasonn [ 21/Feb/24 ] |
|
ok Doc that has also been added into this issue |
| Comment by Doc [ 20/Feb/24 ] |
|
mrjasonn the other is MC-142590 |
| Comment by mrjasonn [ 20/Feb/24 ] |
|
Also Doc what is the other Minecraft bug already fixed? I can or you add that as well to this same issue |
| Comment by mrjasonn [ 19/Feb/24 ] |
|
Just noticed that a second account would be needed to test this, don't have that and don't know anyone else playing Minecraft, so someone else that is someone capable to test this would have to test this. I apologise for the inconvenience. |
| Comment by Doc [ 19/Feb/24 ] |
|
mrjasonn You can try run BuildTools with the PR for testing. like: java -jar BuildTools.jar --rev 4046 --compile spigot --pr craftbukkit:1358
|
| Comment by mrjasonn [ 19/Feb/24 ] |
|
I don't have access to see pull requests, so I can't download the jar (if it even automatically builds one for you to test on Bitbucket) without this unneeded fix. Maybe someone else that has access can help with it. |
| Comment by md_5 [ 18/Feb/24 ] |
|
Have you tested without? Often CraftBukkit patches can interact with the server in different ways to vanilla |
| Comment by Doc [ 18/Feb/24 ] |
|
Created PR for this and another MOJIRA already fixed. https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/1358/overview
|