[SPIGOT-7520] Attribute LootTableSeed missing for generated containers with attached LootTable Created: 14/Nov/23 Updated: 25/Dec/24 Resolved: 15/Nov/23 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Simon Stroh | Assignee: | Marvin Rieple |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Any |
||
| Attachments: |
|
| Version: | This server is running CraftBukkit version 3937-Bukkit-864f616 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) |
| Guidelines Read: | Yes |
| Description |
|
I recently noticed that containers with attached LootTables in structures no longer store the LootTableSeed attribute, which results in non deterministic container content(when recreating a world with the same seed and reopening the same chest its contents will be different, which isn't vanilla behaviour). I first noticed the bug in 1.20.2 builds for paper but the current spigot and craftbukkit builds show the same behaviour, while the vanilla client/server still stores the LootTableSeed. So i would assume the bug was introduced by bukkit/craftbukkit. Steps to reproduce:
Alternatively:
When recreating these steps on a vanilla 1.20.2 server the LootTableSeed attribute is present. For some additional context: |
| Comments |
| Comment by Simon Stroh [ 14/Nov/23 ] |
|
I'm unable to see the PR or the branch it was made from. But the patch seems to work. All chests i checked had the LootTableSeed attribute. |
| Comment by Marvin Rieple [ 14/Nov/23 ] |
|
Made a PR for this: craftbukkit#1300 You can test it with BuildTools: java -jar BuildTools.jar --rev 3939 --compile SPIGOT --pr craftbukkit:1300 |
| Comment by Simon Stroh [ 14/Nov/23 ] |
|
Affected LootTables are: Overworld:
Nether: minecraft:chests/bastion_other
End: |
| Comment by Simon Stroh [ 14/Nov/23 ] |
|
It definitely affects ancient_city chests. I will test it for other structures later. |
| Comment by Black Hole [ 14/Nov/23 ] |
|
Using "/data get block ~ ~ ~" while standing on a chest is much easier. |
| Comment by Marvin Rieple [ 14/Nov/23 ] |
|
Does it affect every structure, which structures did you test specifically? |