[SPIGOT-7417] Add computeVisibleSide method for Sign Created: 30/Jun/23 Updated: 25/Dec/24 Resolved: 17/Feb/24 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Minor |
| Reporter: | DaMarine | Assignee: | coll1234567 |
| Resolution: | Fixed | Votes: | 4 |
| Labels: | None | ||
| Version: | 1.20.1 |
| Guidelines Read: | Yes |
| Description |
|
In 1.20, signs have two sides that can be interacted with - written on, dyed, coloured, or made to glow. Now there's the side of the sign to consider. In order to calculate this side from something like PlayerInteractEvent, you need to do some math based on player vector and block facing. Now that signs have even more interaction methods, this use case in the API strikes me as sensible, in order to avoid everyone having to write their own logic to calculate the side. With both https://hub.spigotmc.org/jira/browse/SPIGOT-7396 and https://hub.spigotmc.org/jira/browse/SPIGOT-7412 it would seem that there are a number of gaps in the API for signs still outstanding, and each of these being reported in quick succession bolsters the argument for one another. This may well want to be bundled into https://hub.spigotmc.org/jira/browse/SPIGOT-7396, depending on implementation. |
| Comments |
| Comment by mrjasonn [ 11/Feb/24 ] |
|
This issue will probably be closed when it is addressed, because that is how things are usually done around here. This does not mean if there is a pull request that exists that addresses this the issue will be closed. But this does not mean that if it won't be added the issue won't be closed. Ultimately it isn't for me to decide, just trying to say how things are usually done around here. |
| Comment by Nathan (antiPerson) [ 04/Feb/24 ] |
|
Can this be closed? This seems to have been added in https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/888/overview |