[SPIGOT-7394] Signs sendSignChange method bug, different one Created: 14/Jun/23  Updated: 25/Dec/24

Status: Open
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Zrips Assignee: Unassigned
Resolution: Unresolved Votes: 4
Labels: None

Version: 1.20
Guidelines Read: Yes

 Description   

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/5863a2eaefe37920cbfa7dbd04f35f0cb2555cfa#src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java?f=698

This line is incorrect, should be

Preconditions.checkArgument(lines.length <= 4, "lines (%s) must be 4 or less", lines.length); 

As now it can only work with 3 lines being passed and not all 4



 Comments   
Comment by md_5 [ 14/Jun/23 ]

Seeing as the API docs say "     * @throws IllegalArgumentException if lines is non-null and has a length less than 4", I've reverted to the original check for the minute, but I think the API contract could be modified as you suggest

Generated at Tue Apr 15 09:10:58 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.