[SPIGOT-7068] SKULK and SKULK_VEIN BlockSpreadEvents Still do not reference the correct source (SKULK_CATALYST) Created: 17/Jun/22 Updated: 25/Dec/24 Resolved: 19/Jun/22 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Llm Dl | Assignee: | Marvin Rieple |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 1.19 | ||
| Environment: |
windows, java 17 |
||
| Version: | This server is running CraftBukkit version 3528-Spigot-56be6a8-031eaad (MC: 1.19) (Implementing API version 1.19-R0.1-SNAPSHOT) |
| Guidelines Read: | Yes |
| Description |
|
Even after the https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/8fda4b12fd066f53d2c0035d4aba3b04cdc49bb7 commit which altered the source block of a sculk and sculk_vein BlockSpreadEvent, I am seeing BlockSpreadEvents that have source blocks of Sculk and Sculk_Vein.
Using code that checks if a sculk_catalyst is in an area that cannot build into the second area where sculk is spreading I am able to deny the BlockSpreadEvent when it is a sculk block being made, but not when it is a sculk_vein that is being made.
I'm not sure if its intentional for sculk and sculk_vein's to still show up as a Source block. I know it has to creep from somewhere but with the current implementation not always pointing to the Sculk_Catalyst makes it a bit tricky to tell if someone is trying to grow sculk into areas they cannot otherwise build in. |
| Comments |
| Comment by Llm Dl [ 20/Jun/22 ] |
|
Marvin: Thank you, this did solve things in my testing, everything appears with a SCULK_CATALYST as the source now. |
| Comment by Marvin Rieple [ 18/Jun/22 ] |
|
Made a PR for this: craftbukkit#1074 |