[SPIGOT-7003] PlayerAnimationEvent incomplete PlayerAnimationType Created: 17/Apr/22 Updated: 25/Dec/24 Resolved: 09/Jun/22 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Photon | Assignee: | Doc |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Version: | This server is running CraftBukkit version 3478-Spigot-42b6152-a459f4d (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) |
| Guidelines Read: | Yes |
| Description |
|
According to wiki.vg the Animation Packet has 2 animations, swinging either main or off hand: https://wiki.vg/Protocol#Animation_.28serverbound.29
However, the PlayerAnimationType of the PlayerAnimationEvent only has one animation in its enum so far: ARM_SWING (probably main hand?).
If this event should also satisfy the clientbound packets (as the cancellable state suggests), then there are more animations missing, like criticals and magic criticals. I also ask this as the javadoc for the event is not really helpful, only stating, "Represents a player animation event". https://wiki.vg/Protocol#Entity_Animation_.28clientbound.29 |
| Comments |
| Comment by Doc [ 18/Apr/22 ] |
|
Created PR for handle this. https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/739/overview https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/1043/overview |