[SPIGOT-6769] EntityDamageEvent.DamageCause for stalactites and stalagmites Created: 23/Oct/21 Updated: 27/Oct/21 Resolved: 27/Oct/21 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Minor |
| Reporter: | TheoRetisch1 | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | event | ||
| Version: | 1.17.1 |
| Guidelines Read: | Yes |
| Description |
|
There are vanilla death messages for death by stalactites and stalagmites, unfortunately there is no EntityDamageEvent.DamageCause event for it (https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/entity/EntityDamageEvent.DamageCause.html). It would be fantastic if stalactites and stalagmites could be added. |
| Comments |
| Comment by md_5 [ 24/Oct/21 ] |
|
Just to add to this, is Doc's explanation sufficient? |
| Comment by Doc [ 23/Oct/21 ] |
|
Created PR bukkit#666 for clarify this case.
For player fall in dripstone the DamageCause is CONTACT and is handled by EntityDamageByBlockEvent, but when a Dripstone fall into player then the DamageCause is FALLING_BLOCK and is handled by EntityDamageByEntityEvent because the falling blocks are entities. |
| Comment by Doc [ 23/Oct/21 ] |
|
The cause for this two blocks are DamageCause.CONTACT or DamageCause.FALLING_BLOCK, then the feature can be change the docs about this damage because currently only explain about cactus.
PD: Maybe im confusing when a entity fall in this blocks.. |