[SPIGOT-6720] Bed explosion checks for DimensionManager#isNatural() instead of DimensionManager#isBedWorks() Created: 24/Aug/21  Updated: 27/Aug/21  Resolved: 27/Aug/21

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Doclic Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: Craftbukkit, bug, spigot
Environment:

OS: Windows 10, also tested on a Debian VPS
IDE: IntelliJ IDEA Community

Note: I used BuildTools to get the Spigot source and use breakpoints to find the source of the issue easily

Version: CraftBukkit version 3212-Spigot-ff89b97-2cdc6b1 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT)
Plugin: A test plugin I made
Guidelines Read: Yes

 Description   

I tried using Reflection the set the "C" ("bedWorks" in Mojang mappings) field and the "D" ("respawnAnchorWorks" in Mojang mappings) field of the DimensionManager of my World. Respawn anchor worked as intended but beds didn't change. So I asked for help on the Spigot forums and no real fix to the problem. After that I tried using the Spigot source to find the issue. I found that the bed explosion check was moved to EntityPlayer by CraftBukkit. And it checks for DimensionManager#isNatural(). I checked for usages of this method and it's also used for Piglin spawning at portals in the overworld.

TL;DR: Bed explosion checks for DimensionManager#isNatural() instead of DimensionManager#isBedWorks() in EntityPlayer#getBedResult(BlockPosition, EnumDirection)

 Comments   
Comment by Doc [ 25/Aug/21 ]

Currently in CB has a PR for fix this logic like vanilla. craftbukkit#905  (where handle the bedWorks like isNatural and in bedfail check again for bedworks for explode like vanilla)

Well based in wiki and vanilla code... for beds the dimension has two configs:

  • isNatural -> in the case of beds only set if player can save and use beds, this value is not used for explode
  • isBedWorks -> like is natural but if false the bed explode, this can override isNatural in vanilla

 

in RespawnAnchor... only use the value of isRespawnAnchorWorks for explode or work.

Comment by Doclic [ 24/Aug/21 ]

What's the difference? Aren't beds just supposed to explode when they don't work? When I set "D" ("respawnAnchorWorks") to true/false it toggles respawn anchors exploding, if the anchor doesn't explode it works normally, even in the overworld

Comment by md_5 [ 24/Aug/21 ]

From memory it's not as simple as this because one value handles beds exploding,t he other handles beds working

Generated at Thu Apr 03 16:05:31 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.