[SPIGOT-6714] PlayerBucketFillEvent called even if bucket cannot be filled Created: 17/Aug/21 Updated: 18/Aug/21 Resolved: 18/Aug/21 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Bjarne Koll | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 1.17.1, bug | ||
| Version: | 3219-Spigot-b166a49-8c6d60c |
| Guidelines Read: | Yes |
| Description |
|
The current spigot PlayerBucketFillEvent is called even if the player does not actually fill up their bucket. You may reproduce this by right clicking a waterloggable block, such as stairs, that are not waterlogged at the time. A possible easy solution would be to simply ensure that the `dummyFluid` fetched prior to the event call is not empty. This would ensure that only non-air item results (e.g. water buckets) trigger the event. |
| Comments |
| Comment by Bjarne Koll [ 17/Aug/21 ] |
|
A PR for this was kindly opened by @NoahvdAa here to make this as quick of a fix as possible. |