[SPIGOT-6523] Custom Dimensions Do Not Work In 1.17 (maybe?) Created: 12/Jun/21 Updated: 25/Aug/21 Resolved: 12/Jun/21 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | Bug | Priority: | Major |
Reporter: | Nikolas | Assignee: | Unassigned |
Resolution: | Invalid | Votes: | 0 |
Labels: | DataPacks, bug | ||
Environment: |
Ubuntu, Java 16 |
Attachments: |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
||||||||
Issue Links: |
|
||||||||
Version: | This server is running CraftBukkit version 3117-Spigot-66f9d3c-4ac634a (MC: 1.17) (Implementing API version 1.17-R0.1-SNAPSHOT) You are 4 version(s) behind | ||||||||
Plugin: | none | ||||||||
Guidelines Read: | Yes |
Description |
I have been updating a server that uses a custom dimension in a datapack. It worked throughout the Vanilla snapshots and Release Candidate 2. It does not work in Spigot. Spigot generates a folder path in the "/minecraft/world_kingdoms_spawn" directory that custom dimension datapacks ignore. Usually the directory for the dimension would happen in the "/minecraft/world/dimensions" folder but instead tries to put itself at "/minecraft/" folder. I cannot guarantee that it is not my fault, but I tried it several ways. I am solid enough to upgrade 4 out of 5 servers... but this one doesn't seem to work with spigot. It could be just something simple. but I will bash a head at a brick wall all of tomorrow! I appreciate the Spigot team, take a bit of a break!!! Good work! |
Comments |
Comment by Tamzid Rahman [ 25/Aug/21 ] |
Hello, so how exactly do I fix this issue in 1.17, because I still have it. A small walkthrough would be very helpful! Thank you. |
Comment by Norbert [ 09/Jul/21 ] |
Hey, I'm the author of that plugin. I made the plugin because Spigot didn't support custom dimensions in 1.16 at all, now it seems to support them, though I haven't done a lot of testing. The dimension folder name doesn't break the namespaces as they are treated separately. In my plugin I also added an option to rename dimensions in Bukkit. The name Bukkit uses can be anything, the plugins will see that name and the world folder is named after that, while the key of the dimension is used by the vanilla server and depends on the datapack. If you're still having this issue, add "type":"minecraft:overworld" before the "generator" key. I haven't tried the datapack but I noticed this. The flat type is kind of misleading, it's different than the dimension type. The dimension type has a lot of settings that you had initially but if you want to alter those then you will need to create a separate dimension type according to the Wiki, I'm not sure why does it work in vanilla that way. |
Comment by Nikolas [ 12/Jun/21 ] |
It seems other people have had this problem with Spigot in the past as well. Someone made a plugin to fix it in 1.16.5. https://www.spigotmc.org/resources/1-16-custom-dimensions.83731/ |
Comment by Nikolas [ 12/Jun/21 ] |
{ "generator": { "seed": 0, "type": "minecraft:flat", "settings": { "biome": "minecraft:mushroom_fields", "lakes": false, "features": false, "layers": [ { "block": "minecraft:grass_block", "height": 1 } ], "structures": { "structures": {} } } } } I changed the .json and got rid of the "type" segments. Still does not work in Spigot. |
Comment by md_5 [ 12/Jun/21 ] |
No the dimension type is used for "type", the first dozen lines of your screenshot |
Comment by Nikolas [ 12/Jun/21 ] |
The "dimension_type" folder is only for custom dimension types. I am using "minecraft:flat" as my dimension type shown in the .json file in the image above that generates my custom Dimension. The "name" key that you say doesn't seem to be used is what is used to create the namespace. When loading this datapack, Vanilla will create a "dimensions/kingdoms/spawn" folder. Datapacks rely on the namespace "kingdoms:spawn" (in my case) to access the custom Dimension. Spigot does not create a "dimensions/kingdoms/spawn" folder. It instead tries to create a folder called "world_kingdoms_spawn" in the root Minecraft directory. This breaks the namespace system, making it invalid when trying to access in game. |
Comment by md_5 [ 12/Jun/21 ] |
The solution is to make a dimension_type folder like the wiki says and vanilla does |
Comment by Nikolas [ 12/Jun/21 ] |
I'll dig into it more when I wake up. It is 4am. If I can get it running in Spigot, I will let you know my solution. |
Comment by md_5 [ 12/Jun/21 ] |
Yeah sorry I didn't catch the caves the first time round, but I still think the pack is technically invalid even though it does work on vanilla |
Comment by Nikolas [ 12/Jun/21 ] |
Oh! Good to know! I will read up on that! Thanks! Although, I got this to load into a Vanilla 1.17 server just fine using the same methods as before. Here is a screenshot of that: (Same Datapack, be sure you are using CavesAndCliffsPreview.zip datapack with it too, like I mentioned above.) |
Comment by md_5 [ 12/Jun/21 ] |
I just looked further, your datapack has the same issue as the private one in SPIGOT-6490 Quoting from that ticket: These datapacks are defined with "type" put inside the dimension rather than in the dimension_type folder. The MC wiki also says "type" should be a string rather than dimension object: https://minecraft.fandom.com/wiki/Custom_dimension |
Comment by md_5 [ 12/Jun/21 ] |
Single player is not the same as the server. |
Comment by Nikolas [ 12/Jun/21 ] |
You don't need to insult my datapack skills. I know they are bad, but come on man... >.< This works as intended in 1.17. You should arrive in the kingdoms:spawn dimension like I did upon loading in like the screenshots above. |
Comment by Nikolas [ 12/Jun/21 ] |
What? I just attached a file proving it runs in 1.17 Vanilla as intended. I can run it in a server version if you would like? |
Comment by md_5 [ 12/Jun/21 ] |
The attached datapack is full of errors and does not work even on Vanilla 1.17 |
Comment by Nikolas [ 12/Jun/21 ] |
I don't know if I made this clear, but I am running the CavesAndCliffPreview.zip as well. I don't know if that would interfere. It did not in Vanilla. |
Comment by Nikolas [ 12/Jun/21 ] |
I attached the datapack. It wouldn't surprise me if you came back and said I done messed up! Thanks for your help! |
Comment by md_5 [ 12/Jun/21 ] |
The path spigot puts it in is normal though, that's not the issue (if any) |
Comment by md_5 [ 12/Jun/21 ] |
Attach the datapack please |