[SPIGOT-652] Bukkit map palette needs to be updated for 1.8.3 Created: 07/Mar/15 Updated: 07/Mar/15 Resolved: 07/Mar/15 |
|
| Status: | Closed |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Bobcat00 | Assignee: | Thinkofname |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Win7 |
||
| Description |
|
The Minecraft map item palette was updated in 1.8.1. The palette is duplicated in Bukkit / src / main / java / org / bukkit / map / MapPalette.java The palette should be updated to match what is used in the real Minecraft 1.8.3. I've entered the palette data here http://pastebin.com/4uaxbjTG (although I changed the line spacing from the current format). ref: http://minecraft.gamepedia.com/Map_item_format#Map_colors (Note the version string is from 1.8, but Jira requires me to populate this field.) |
| Comments |
| Comment by Thinkofname [ 07/Mar/15 ] |
|
server, net.minecraft.server.MaterialMapColor |
| Comment by Bobcat00 [ 07/Mar/15 ] |
|
Where does MaterialMapColor come from? I can't find it. Is that from Mojang code? Client or server? |
| Comment by Thinkofname [ 07/Mar/15 ] |
|
Bobcat00 I used the values in MaterialMapColor, split into rgb and multiplied each by {180, 220, 255, 135}and divided by 255 |
| Comment by Thinkofname [ 07/Mar/15 ] |
|
Its only off by one, could just be a rounding error either on my part or the wikis (or maybe a quirk with how the client renders the colors) |
| Comment by Bobcat00 [ 07/Mar/15 ] |
|
Just did another test with the 1.8 client, and I'm still seeing the same colors as with 1.8.1 and 1.8.3. So perhaps my test is not valid (could be caused by Minecraft lighting issues. Heh) How did you generate your values? |
| Comment by Bobcat00 [ 07/Mar/15 ] |
|
@Thinkofdeath I just test a test with both 1.8.1 and 1.8.3 clients by posting a map with colors 4 and 5. I see the colors in the Wiki shown for 1.8.1: 88,124,39 and 108,151,47. The wiki appears to be correct, at least for these two colors. So perhaps you're not calculating the colors the same way the client does. (The purpose of the palette defined by Bukkit is to match what the client uses.) |
| Comment by Thinkofname [ 07/Mar/15 ] |
|
Bobcat00 instead of using the wiki I generated the values from the ones used internally. The wiki is wrong as far as I can tell |
| Comment by Bobcat00 [ 07/Mar/15 ] |
|
@Thinkofdeath It looks like you didn't make all the changes. There are more entries that need to be changed. |