[#SPIGOT-6434] Smithing Table and Anvil inventories .getType() returns CRAFTING

[SPIGOT-6434] Smithing Table and Anvil inventories .getType() returns CRAFTING Created: 23/Apr/21 Updated: 24/Apr/21 Resolved: 24/Apr/21
Status:	Resolved
Project:	Spigot
Component/s:	None
Affects Version/s:	None
Fix Version/s:	None

Type:

Bug

Priority:

Minor

Reporter:

Prof Bloodstone

Assignee:

Unassigned

Resolution:

Fixed

Votes:

Labels:

InventoryOpenEvent,, event

Version:

[22:06:29] [Server thread/INFO]: This server is running CraftBukkit version 3048-Bukkit-9db9aee (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT) [22:06:29] [Server thread/INFO]: Checking version, please wait... [22:06:30] [Thread-20/INFO]: Yo

Guidelines Read:

Yes

Description

This issue exists in both Spigot and CraftBukkit.

When InventoryOpenEvent is called, the Inventory Type's default title is set to `Crafting` when opening Anvil and Smithing Tables. All other blocks I tested seem to work.

Reproduce:

@EventHandler
public void onInventoryOpenEvent(InventoryOpenEvent event) {
  Player player = (Player) event.getPlayer();
  player.sendMessage(event.getInventory().getType().getDefaultTitle());
}

Comments

Comment by Prof Bloodstone [ 24/Apr/21 ]

That's understandable, I'm sorry. Thought sharing it here could help make things quicker, given that I don't have stash account and haven't had need nor the time to understand Spigot CLA. Maybe one day that'll change, but for now I'll keep in mind not do post those fixes.

Comment by md_5 [ 24/Apr/21 ]

Please do not post patches outside of Stash

Comment by Prof Bloodstone [ 24/Apr/21 ]

The issue is that the InventoryType enum has correct entries already:

    /**
     * A player's crafting inventory, with 4 CRAFTING slots and a RESULT slot.
     * Also implies that the 4 ARMOR slots are accessible.
     */
    CRAFTING(5, "Crafting", false),
    /**
     * An anvil inventory, with 2 CRAFTING slots and 1 RESULT slot
     */
    ANVIL(3, "Repairing"),
    /**
     * A smithing inventory, with 2 CRAFTING slots and 1 RESULT slot
     */
    SMITHING(3, "Upgrade Gear"),

Just wrong type is being returned.
This seems to be caused by this commit: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches/net/minecraft/world/inventory/ContainerAnvilAbstract.patch#7,23
It seems to have changed `repairInventory` into a `InventoryCrafting` instead of previous `InventorySubcontainer`.

Fixing it is a matter of moving the anvil and smithing table checks inside of `CraftInventory.getType()` to the top.

Comment by Prof Bloodstone [ 23/Apr/21 ]

Hmm that's a good point. It's weird though that both anvil and smithing table have `CRAFTING` inventory type. Not sure if they should get separate fields in enum? Don't know what was the reasoning behind that. This doesn't seem consistent with the rest of the enum:

[00:52:39 INFO]: Type: STONECUTTER, Inventory Title: Stonecutter
[00:52:44 INFO]: Type: GRINDSTONE, Inventory Title: Repair & Disenchant
[00:52:47 INFO]: Type: WORKBENCH, Inventory Title: Crafting
[00:52:49 INFO]: Type: CRAFTING, Inventory Title: Crafting
[00:52:50 INFO]: Type: CRAFTING, Inventory Title: Crafting
[00:52:56 INFO]: Type: BLAST_FURNACE, Inventory Title: Blast Furnace

The issue is that now you can't for example check what title would be shown to the user by default.

Maybe I'm missing something?

Comment by md_5 [ 23/Apr/21 ]

Inventory type is an enum, so this is obviously expected.
You want to get the title from the view.

Generated at Thu Apr 03 16:47:36 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.

[SPIGOT-6434] Smithing Table and Anvil inventories .getType() returns CRAFTING Created: 23/Apr/21 Updated: 24/Apr/21 Resolved: 24/Apr/21