[SPIGOT-6294] Hidden Crafting Advancements counted as Regular Advancements Created: 27/Dec/20  Updated: 27/Dec/20  Resolved: 27/Dec/20

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Kris Assignee: Unassigned
Resolution: Duplicate Votes: 1
Labels: spigot
Environment:

Tested on both a Windows 10 and Linux OS. Hardware isn't an issue.


Issue Links:
Duplicate
duplicates SPIGOT-5885 Can't disable advancements Reopened
Version: CraftBukkit version git-Spigot-628435a-6917945 (MC: 1.16.4) (API version: 1.16.4-R0.1-SNAPSHOT)
Plugin: AdvancedAchievements
Guidelines Read: Yes

 Description   

I have come across what me and a developer believe to be a spigot issue. When taking into account advancements, there are the player achieved ones and apparently also hidden crafting ones that I would not have known were advancements unless I came to this particular conclusion. When disabling the minecraft advancements using the spigot.yml node for doing so, it disables player-achieved ones, but not crafting ones. So to my knowledge, there are ~900 crafting achievements that are let pass even though the entire default minecraft story is disabled. This is an extreme hinderence, as trying to use this plugin to count AdvancedAchievements only is near impossible, as crafting advancements persist without a way to disable them.

The developer has cited this as a similar bug; https://hub.spigotmc.org/jira/browse/SPIGOT-5700

"Each recipe indeed has an advancement associated with it. But one would expect that disabling all 'minecraft' advancements disables [the crafting hidden advancements] as well. This not happening seems like a bug to me, and I think we should report a new bug on the Spigot issue tracker."

The entire issue is documented here, on this github bug report to the developer;

https://github.com/PyvesB/advanced-achievements/issues/914

 



 Comments   
Comment by md_5 [ 27/Dec/20 ]

There is no such thing as hidden advancements.
This is simply a duplicate of SPIGOT-5885 and can be worked around by reloading advancements after the server starts

Comment by Pyves [ 27/Dec/20 ]

From the Spigot API's perspective, PlayerAdvancementDoneEvents are still being fired for the Minecraft namespace even though all advancements for that namespace have been disabled using the configuration outlined in SPIGOT-6164.{{}}

Generated at Tue Apr 08 01:38:26 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.