[SPIGOT-6249] Add Missing Effect Constants Created: 21/Nov/20 Updated: 11/Sep/21 Resolved: 11/Sep/21 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | New Feature | Priority: | Minor |
Reporter: | Martin | MiniDigger | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | None |
Version: | master/f47abd8878a775a446e9608a7ee1584cf827c015 |
Guidelines Read: | Yes |
Description |
Minecraft has 60 Level Events (called Effect in Bukkit), documented for example here: https://wiki.vg/Protocol#Effect Bukkit only defines enum constants for 46 of those, without giving a developer any other way to send non defined or non standard effects: The remaining constants should be added |
Comments |
Comment by Marvin Rieple [ 09/Sep/21 ] |
Made a PR for this: bukkit#659 |
Comment by md_5 [ 05/Jan/21 ] |
|
Comment by Martin | MiniDigger [ 05/Jan/21 ] |
@md_5, somebody PRd this to paper before I had time looking into it. I would PR it upstream, but we are unsure about the legal situation, since the OG author of the patch doesn't want to sign spigots CLA. I have signed the CLA before, so it wouldn't be an issue for me to upstream his patch, and his patch is MIT. what do you think? |
Comment by md_5 [ 27/Dec/20 ] |
Feel free to document and PR them |