[SPIGOT-5716] IllegalArgumentException caused by hasFace method in Spigot API Created: 04/May/20  Updated: 09/May/20  Resolved: 09/May/20

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: kikelkik Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: BlockState, Exception, craftbukkit
Environment:

with CraftBook version 3.10.2-SNAPSHOT;4586-0c3ad1c

Version: git-Paper-240 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
Guidelines Read: Yes

 Description   

In this Issue for CraftBook I described the error.
It seems that somewhere since org.bukkit.craftbukkit.v1_15_R1.block.impl.CraftVine.hasFace there might be the reason for this error.

The call `vine.hasFace(test.getOppositeFace())` here guarantees that neither `vine` nor `test.getOppsiteFace()` can ever be null. It should be enough to read the 10 lines before.

That's the reason why I think, there must be a bug within the Spigot API.

CraftBook error



 Comments   
Comment by md_5 [ 05/May/20 ]

Yeah this isn't a bug aside from maybe unclear docs. The behaviour of this method has always been this (and is logical behaviour, since hasFace on a face that can't be assigned is illogical)

Comment by Black Hole [ 04/May/20 ]

Vine extends MultipleFacing. That interface declares a method getAllowedFaces to check if a face is supported. Vine supports all faces except DOWN.

Maybe the error message and the JavaDoc could be improved?

Generated at Thu Apr 03 16:05:22 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.