[SPIGOT-5681] Plugin Channel length does not match vanilla restrictions Created: 19/Apr/20 Updated: 22/Apr/20 Resolved: 22/Apr/20 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | Bug | Priority: | Minor |
Reporter: | Mitchell Skaggs | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 1 |
Labels: | Channel, plugin, vanilla |
Attachments: |
![]() |
Version: | git-Spigot-ae72bf4-183139d |
Guidelines Read: | Yes |
Description |
During the 1.13 update, the limit on the length of plugin channel names was removed (source). Independent inspection of the source code via Fabric confirms that this restriction is definitely removed in 1.15.
The 1.13-pre7 update to Spigot by @md_5 changed the limit to 32, but did not remove it like in Vanilla: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/f8b2086d60942eb2cd7ac25a2a1408cb790c222c#src/main/java/org/bukkit/plugin/messaging/Messenger.java
I encountered this issue when a user of my mod was unable to join a Spigot server, but could join Vanilla and Fabric servers: magneticflux-/fabric-mumblelink-mod#22. |
Comments |
Comment by Mitchell Skaggs [ 20/Apr/20 ] |
In general, I think any difference in behavior from Vanilla should be configurable. I'm sure that's not possible for everything, but having configuration options for divirging behavior would solve a lot of potential issues with interoperability. |
Comment by Mitchell Skaggs [ 19/Apr/20 ] |
I think a maximum realistic identifier would be 128 chars, and the limit should be double that: 256 chars. Yes it's 8 times larger that the current limit, but it's still only 1/128 the Vanilla limit. |
Comment by md_5 [ 19/Apr/20 ] |
By design, 'unlimited' length fields are bad. |