[SPIGOT-5590] Crafting Recipe's Ingredient MetaData ignored Created: 19/Feb/20 Updated: 20/Feb/20 |
|
| Status: | Open |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Terrence Monroe | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | bukkit | ||
| Version: | git-Spigot-c574e08-37f32da (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT) |
| Guidelines Read: | Yes |
| Description |
|
I'm not sure if this is the place to post this. I did a quick google search and found no information on this. ShapedRecipe.setIngredient(char key, MaterialData ingredient) does not implement metadata as it would so suggest Tracing the API, it uses deprecated methods that converts MaterialData into a Material object and a raw int. the int never actually gets used in the end, so all your left with is a Material object, thus losing any metadata the ingredient had initially. This makes using certain items impossible. For example coding a recipe that requires an Enchanted book, will allow using any enchanted book instead of the specific one that was originally set. |
| Comments |
| Comment by Terrence Monroe [ 20/Feb/20 ] |
|
I did read the notice but did not know what Draft API meant. Thanks for clearing that up. |
| Comment by TheCreeperCow [ 20/Feb/20 ] |
|
Have you read the deprecation notice it's a draft api meaning it will be changed and it's methods could change due to that it won't be removed Im pretty sure |
| Comment by Terrence Monroe [ 20/Feb/20 ] |
|
Yes but then I'm left with the same issue. MaterialChoice only focuses on Material. ExactChoice did fix my issue but it being deprecated I'll be needing an alternative solution. |
| Comment by TheCreeperCow [ 20/Feb/20 ] |
|
Correct me if im wrong but i think this is what md_5 is referring to https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/RecipeChoice.MaterialChoice.html |
| Comment by md_5 [ 19/Feb/20 ] |
|
https://hub.spigotmc.org/javadocs/spigot/index.html?overview-summary.html |
| Comment by Terrence Monroe [ 19/Feb/20 ] |
|
There any documentation? I see ExactChoice but that is also deprecated.. |
| Comment by md_5 [ 19/Feb/20 ] |
|
MaterialData does not store enchants anyway, and is deprecated. You need to be using the Recipe choice API if you want enchants to be respected. |