[SPIGOT-5438] Updating a sign type using BlockState.type resets it's facing Created: 11/Dec/19 Updated: 12/Jan/20 Resolved: 12/Jan/20 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | KoekenMeneer | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | BlockState, Material, Signs | ||
| Issue Links: |
|
||||||||
| Version: | This server is running CraftBukkit version git-Spigot-56f8471-6567017 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT) | ||||||||
| Guidelines Read: | Yes | ||||||||
| Description |
|
When changing a sign type, from say DARK_OAK_WALL_SIGN to OAK_WALL_SIGN using BlockState.type and than calling update(), the lines persist, but the facing resets. I expect the facing to be retained as well. |
| Comments |
| Comment by md_5 [ 11/Dec/19 ] |
|
Yes, this is definitely not a bug.
setType(Material) is equivalent to setBlockData(Material.createBlockData()) — should be obvious there why the direction is not kept.
I'm only keeping the ticket open to see why exactly the lines are kept, though I don't think that will be changed |
| Comment by KoekenMeneer [ 11/Dec/19 ] |
|
Forgot to mention it, but it only happens when force=true. Also, just to make sure, but it's not a client-side bug either |
| Comment by md_5 [ 11/Dec/19 ] |
|
No, this should definitely not happen as they are two different block data's. Personally I'm a little surprised the lines are kept. |